Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neel/spatial map answer extraction #57

Merged
merged 11 commits into from
Jan 29, 2025
Merged

Neel/spatial map answer extraction #57

merged 11 commits into from
Jan 29, 2025

Conversation

neelsj
Copy link
Collaborator

@neelsj neelsj commented Dec 7, 2024 •
edited
Loading

This PR is a set of changes to update and simplify the answer extraction or Spatial Map and Maze. Removes model specific answer extraction

vidhishanair
vidhishanair reviewed Dec 9, 2024
View reviewed changes
eureka_ml_insights/data_utils/spatial_utils.py Show resolved Hide resolved
eureka_ml_insights/data_utils/spatial_utils.py Outdated Show resolved Hide resolved
eureka_ml_insights/metrics/metrics_base.py Outdated Show resolved Hide resolved
eureka_ml_insights/metrics/metrics_base.py Outdated Show resolved Hide resolved
vidhishanair
vidhishanair previously approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@vidhishanair vidhishanair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

safooray
safooray requested changes Dec 11, 2024
View reviewed changes
eureka_ml_insights/data_utils/__init__.py Show resolved Hide resolved
eureka_ml_insights/metrics/metrics_base.py Outdated Show resolved Hide resolved
eureka_ml_insights/metrics/metrics_base.py Outdated Show resolved Hide resolved
eureka_ml_insights/metrics/metrics_base.py Outdated Show resolved Hide resolved
eureka_ml_insights/user_configs/vision_language/maze.py Outdated Show resolved Hide resolved
eureka_ml_insights/data_utils/spatial_utils.py Show resolved Hide resolved
@neelsj neelsj merged commit bbe1f72 into main Jan 29, 2025
6 checks passed
@neelsj neelsj deleted the neel/spatial_map_answer_extraction branch January 29, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@safooray safooray safooray approved these changes

@vidhishanair vidhishanair vidhishanair left review comments

Assignees

@vidhishanair vidhishanair

@safooray safooray

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neelsj @vidhishanair @safooray